Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(machinelearning): removal of readyForAssociation and NOT_ASSOCIATED #885

Merged
merged 1 commit into from
Nov 18, 2024
Merged

feat(machinelearning): removal of readyForAssociation and NOT_ASSOCIATED #885

merged 1 commit into from
Nov 18, 2024

Conversation

lprovost-coveo
Copy link
Contributor

@lprovost-coveo lprovost-coveo commented Nov 13, 2024 •
edited
Loading

Removal of readyForAssociation in favor of requiresAssociation
At the same time the status "NOT_ASSOCIATED" is no longer available also in favor of the switch to requiresAssociation

BREAKING CHANGE: Property will be removed and unavailable

Acceptance Criteria

  • My changes are publicly available, documented, and deployed in production. (i.e. on Swagger)
  • JSDoc annotates each property added in the exported interfaces
  • The proposed changes are covered by unit tests
  • Commits containing breaking changes a properly identified as such
  • README.md is adjusted to reflect the proposed changes (if relevant)
  • My merge commit message will be conventional (See Conventional Commit)

@lprovost-coveo lprovost-coveo requested review from a team as code owners November 13, 2024 21:14
@GermainBergeron
Copy link
Member

Your commit and description mention NOT_ARCHIVED but the code changes update NOT_ASSOCIATED

@lprovost-coveo
feat(machinelearning): removal of readyForAssociation and NOT_ASSOCIA…
d296cbb 
…TED status

BREAKING CHANGE: Property will be removed and unavailable
@lprovost-coveo lprovost-coveo force-pushed the feat/MLX-1618-deprecate-readyForAssociation branch from 633c38e to d296cbb Compare November 18, 2024 14:51
@lprovost-coveo
Copy link
Contributor Author

Your commit and description mention NOT_ARCHIVED but the code changes update NOT_ASSOCIATED

fixed 👍

@GermainBergeron GermainBergeron changed the title feat(machinelearning): removal of readyForAssociation and NOT_ARCHIVED feat(machinelearning): removal of readyForAssociation and NOT_ASSOCIATED Nov 18, 2024
@lprovost-coveo lprovost-coveo added this pull request to the merge queue Nov 18, 2024
Merged via the queue into master with commit 3bdd7c2 Nov 18, 2024
6 checks passed
@lprovost-coveo lprovost-coveo deleted the feat/MLX-1618-deprecate-readyForAssociation branch November 18, 2024 15:45
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 57.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JTangCoveo JTangCoveo JTangCoveo approved these changes

@GermainBergeron GermainBergeron GermainBergeron approved these changes

@FelixBlaisThon FelixBlaisThon Awaiting requested review from FelixBlaisThon FelixBlaisThon is a code owner automatically assigned from coveo/frontend-foundation

@y-lakhdar y-lakhdar Awaiting requested review from y-lakhdar y-lakhdar is a code owner automatically assigned from coveo/dx

@louis-bompart louis-bompart Awaiting requested review from louis-bompart louis-bompart is a code owner automatically assigned from coveo/dx

@fbeaudoincoveo fbeaudoincoveo Awaiting requested review from fbeaudoincoveo fbeaudoincoveo is a code owner automatically assigned from coveo/dx

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lprovost-coveo @GermainBergeron @JTangCoveo